Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[weblog] Add test for Datadog distributed tracing headers where x-datadog parent-id is set to 0 #3564

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

zacharycmontoya
Copy link
Contributor

Motivation

To connect Synthetics to APM traces, the following Datadog headers are set:

  • x-datadog-trace-id
  • x-datadog-parent-id: 0
  • x-datadog-origin: synthetics or x-datadog-origin: synthetics-browser
  • x-datadog-sampling-priority: 1

This weblog test asserts that library tracers continue the trace when they receive this set of headers.

Changes

Adds new tests:

  • tests/test_distributed.py::Test_Synthetics_APM_Datadog::test_synthetics
  • tests/test_distributed.py::Test_Synthetics_APM_Datadog::test_synthetics_browser

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@zacharycmontoya zacharycmontoya changed the title [weblog] [weblog] Add test for Datadog distributed tracing headers where x-datadog parent-id is set to 0 Nov 26, 2024
@zacharycmontoya zacharycmontoya force-pushed the zach.montoya/tracer-parentid-0 branch from d7b3025 to 9803f7c Compare November 26, 2024 19:44
Copy link
Contributor

@link04 link04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…n they receive x-datadog-trace-id=<some_number> and x-datadog-parent-id=0
…st tests/test_data_integrity.py::Test_TraceUniqueness::test_trace_ids
@zacharycmontoya zacharycmontoya force-pushed the zach.montoya/tracer-parentid-0 branch from 946b7fd to ba90973 Compare December 3, 2024 01:34
@zacharycmontoya zacharycmontoya marked this pull request as ready for review December 3, 2024 18:02
@zacharycmontoya zacharycmontoya requested review from a team as code owners December 3, 2024 18:02
@zacharycmontoya zacharycmontoya merged commit 71cb900 into main Dec 4, 2024
282 checks passed
@zacharycmontoya zacharycmontoya deleted the zach.montoya/tracer-parentid-0 branch December 4, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants